Bump IREE to iree-org/iree@c37c680ae6e71#1350
Merged
Abhishek-Varma merged 6 commits intomainfrom Sep 11, 2025
Merged
Conversation
Abhishek-Varma
force-pushed
the
avarma_iree_bump
branch
3 times, most recently
from
72f2edc to
bb54553
Compare
Abhishek-Varma
force-pushed
the
avarma_iree_bump
branch
from
d631fd3 to
b7ddeea
Compare
Signed-off-by: Abhishek Varma <abhvarma@amd.com>
Abhishek-Varma
force-pushed
the
avarma_iree_bump
branch
from
2bfdd63 to
6e818de
Compare
Abhishek-Varma
requested review from
MaheshRavishankar,
Yu-Zhewen,
jtuyls,
newling and
yzhang93
as code owners
Yu-Zhewen
reviewed
Sep 11, 2025
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/KernelDispatch.cpp
Show resolved
Hide resolved
Yu-Zhewen
reviewed
Sep 11, 2025
| ) | ||
| ) | ||
|
|
||
| # TODO: Named Conv* ops are lowered as linalg.generic ops causing issues in the expected |
Collaborator
Contributor
Author
There was a problem hiding this comment.
So we shouldn't really be needing NamedConvOp checks because passes in IREE that aims to generalize a few Named ops convert them into linalg.generic ops.
We should ideally delete the check statements for explicit Named Conv* ops, but I chose to keep it as currently it doesn't break and in future if we there's some upstream changes to bring back named ops, it'd still work.
The above TODO is pertaining specially to depthwise because the matcher implemented in the PR fails to validate it as one.
Yu-Zhewen
approved these changes
Sep 11, 2025
Contributor
Author
|
Merging this as the last IREE bump was 3 weeks ago! Any further changes can be addressed iteratively as a follow-up during the next IREE bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains xrt/xrt-lite changes due to IREE HAL runtime API changes.
Also linalg.Conv* named ops are now lowered as linalg.generic - so a few changes to deal with the same has been added. One of the Conv tests has been disabled for now.
Signed-off-by: Abhishek Varma abhvarma@amd.com