Skip to content

refactor: highlights name overrides for Error subclasses #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2025
Merged

refactor: highlights name overrides for Error subclasses #527

merged 2 commits into from
Jul 15, 2025

Conversation

bjacobgordon
Copy link
Collaborator

@bjacobgordon bjacobgordon commented Jul 15, 2025 •
edited
Loading

  • makes the access more explicit
  • makes the fact that it's an override more explicit
  • puts it closer to the class identifier, which makes it easier to tell that it matches
  • keeps noise out of the constructor body
  • follows up on feature: tighten up error handling #196

@bjacobgordon
refactor(library/Parser): avoids name avoid ride for abstract `Erro…
0706fa0 
…r` subclass
@bjacobgordon
refactor: prefers public override name in Error classes
0e07d37 
- makes the access more explicit
- makes the fact that it's an override more explicit
- puts it closer to the class identifier, which makes it easier to tell that it matches
- keeps noise out of the constructor body
@bjacobgordon bjacobgordon self-assigned this Jul 15, 2025
@bjacobgordon bjacobgordon merged commit 3cb2403 into nod-ai:integration Jul 15, 2025
4 checks passed
@bjacobgordon bjacobgordon deleted the refactor--highlights-name-overrides-for-error-subclasses branch July 15, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjacobgordon bjacobgordon

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bjacobgordon