fix(library/math): guards against infinite operands in greatestCommonDivisor
#538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2025
Merged
bjacobgordon
added a commit
that referenced
this pull request
Jul 17, 2025
…nstructable" (#540) - while `NonActionableError.throw` is the recommended way of constructing and propagating an instance, there's no inherent danger in directly constructing - unblocks #538 - a common way to detect constructors is to check for conformance to an interface like: ```typescript interface DirectlyConstructable { new: (...parameters: any[]): any; } ``` - useful in scenarios where constructors are passed to implementations that "reconstruct" an instance - any class that implements `DirectlyConstructable` will inherently conform to: ```typescript interface InstanceMatchable { [Symbol.hasInstance]: (...parameters: any[]): boolean; } ``` - objects that conform to _this_ interface are guaranteed to be compatible with the `instanceOf` operator - a problem arises when a class regulates constructor usage via static factories - on the one hand, it's no longer "directly constructable" - but on the other, the class can still "have instances" - so, if the goal is to use `instanceOf` and not necessarily "reconstruct" an instance, then conformance to `DirectlyConstructable` is needlessly restrictive.
bjacobgordon
force-pushed
the
fix(library/math)--guards-against-infinite-operands-in-`greatestCommonDivisor`
branch
from
ec25be4 to
d81afe9
Compare
bjacobgordon
force-pushed
the
fix(library/math)--guards-against-infinite-operands-in-`greatestCommonDivisor`
branch
from
d81afe9 to
eb542af
Compare
bjacobgordon
deleted the
fix(library/math)--guards-against-infinite-operands-in-`greatestCommonDivisor`
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.