Ensure dune version installed is appropriate #1904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitag-ha
requested changes
Jul 31, 2025
Co-authored-by: Sonja Heinze <[email protected]>
pitag-ha
reviewed
Aug 1, 2025
Co-authored-by: Sonja Heinze <[email protected]>
pitag-ha
reviewed
Aug 1, 2025
pitag-ha
reviewed
Aug 1, 2025
There was a problem hiding this comment.
Just as a note: there's a lot of logging (the one below is just one out of about 10). @smorimoto , is it ok to leave them all? Or do you prefer @PizieDust to remove (some of) them?
(they're already removed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks that the dune version installed supports all the currrent features of Dune Package Management.
Currently, we check if it's a release or a preview.
If it's a release, we check that the version is gte 3.19.1 and if it's a preview we check that the timestamp is on or after 2025-07-29
This is related to #1833 (comment)
cc @pitag-ha