Check if ocamllsp is present the dune way #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitag-ha
reviewed
Aug 1, 2025
There was a problem hiding this comment.
Perfect, this is much better than the old workaround! Thanks, @PizieDust, and dune devs!
PD: I'm personally not a huge fan of using polymorphic variants all over. But that's just my taste.
pitag-ha
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
LGTM!
I leave it to you and to @smorimoto whether to leave or to remove the changelog entry.
|
Could you please resolve conflicts? |
Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
Co-authored-by: Sonja Heinze <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, wrt Dune package management we check if ocamllsp is present by checking if its found in the
dev-tools.lockdirectory.This PR ocaml/dune#11922 allows us to be able to check for the presence of ocamllsp in a much cleaner way
dune tools which ocamllsp.cc @pitag-ha