prov/lnx, fabtests: add support for lnx in fabtests #11367
+109
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AV_MAP was deprecated, default to AV_TABLE Signed-off-by: Alexia Ingerson <[email protected]>
lnx uses eq_create to create an eq which calls the fabric wait object open function. Since that's not implemented, opening an eq returns ENOSYS. Add the util wait object implementation This lets the user open an EQ (like in fabtests) but this EQ is currently never used Signed-off-by: Alexia Ingerson <[email protected]>
aingerson
force-pushed
the
main
branch
2 times, most recently
from
1737ebb to
5bf405b
Compare
lnx supports iov counts, it just has to be the minimum of all the providers it supports (and less than the global LNX limit). Remove failures for fewer than 1 iov Signed-off-by: Alexia Ingerson <[email protected]>
lnx has to overwrite some of the hints passed into the main getinfo call because they won't be valid for all core providers (for example the remote comm/local comm specification). This also includes the fabric and domain names which won't match the core providers. The protocol setting was missing so if the provider passed in FI_PROTO_LNX, it would fail the core getinfos because of a mismatch. This resets the protocol to a value which won't fail any core providers (FI_PROTO_UNSPEC) Signed-off-by: Alexia Ingerson <[email protected]>
Signed-off-by: Alexia Ingerson <[email protected]>
Signed-off-by: Alexia Ingerson <[email protected]>
|
Verified these changes work when enabling lnx fabtests in our CI which will come later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things were missing to support running lnx with fabtests by default: