Move unnecessary deps from production image into devtest image

[manics]

This is extracted from #38

It moves java/javac into a devtest image, and adds other tools including git.
Note this is Java 8, in keeping with the current OMERO.web standalone image. Now Java 11

---

E.g. make VERSION=x.y.z docker-build

openmicroscopy/omero-web-devtest              x.y.z                          b19c46a849e4        45 seconds ago      1.29GB
openmicroscopy/omero-web-devtest              x.y.z-0                        b19c46a849e4        45 seconds ago      1.29GB
openmicroscopy/omero-web-standalone           x.y.z                          e1faf515dec9        5 minutes ago       932MB
openmicroscopy/omero-web-standalone           x.y.z-0                        e1faf515dec9        5 minutes ago       932MB
openmicroscopy/omero-web                      x.y.z                          560e614ebb93        5 minutes ago       905MB
openmicroscopy/omero-web                      x.y.z-0                        560e614ebb93        5 minutes ago       905MB

[sbesson]

So trying to understand the scope of the three images as defined in this PR, my understanding is the following

• omero-web: minimal OMERO.web image
• omero-web-standalone: minimal image + OMERO.web apps
• omero-web-devtest: minimal image + developer tools

Main question is who will be consuming the third one and for what intent? Is there value in having the third image also including the apps?

[snoopycrimecop]

Conflicting PR. Removed from build DOCKER-merge#1279. See the console output for more details.
Possible conflicts:

• PR Ansible updates #38 manics 'Ansible updates'
  • devtest/Dockerfile
  • requirements.yml

--conflicts Conflict resolved in build DOCKER-merge#1280. See the console output for more details.

[manics]

The devtest image is for use in omero-test-infra. This is the only reason Java is currently installed in the standalone image. With the addition of pre-commit we now also need git so rather than installing more dev dependencies in a production image I think we should put in a separate one.

[joshmoore]

• omero-web-devtest: minimal image + developer tools

... : standalone image + developer tools

[joshmoore]

I'm not a huge fan of the name devtest but the only thing better I can come up with is dev. I do wonder how ome/omero-web#224 is going to impact this. Will this repo become standalone and dev? If so, should this repo be "standalone" and then another could be "dev"? I think I'm missing the overall plan here, but I'm not against this if it helps us make progress toward whatever that goal is.

[joshmoore]

What would take to strip it from test-infra?

[manics]

I don't know, though I suspect it might already work. My intention in this PR was to minimise changes that might impact omero-test-infra, but if you're happy with larger changes I can try removing it.

[manics]

ome/omero-web#224 can eventually replace omero-web (minimal OMERO.web image). This repo would then contain the standalone image, and the devtest. You're right that we could split the repos into single image repos for the standalone and dev/devtest images. Decisions to make are:

• When to make WIP: Rewrite Dockerfile omero-web#224 the minimal production image. I was thinking of waiting until 6.0.0, and in the meantime tag it as something like newprod. We could make the switch earlier though.
• If we don't switch to WIP: Rewrite Dockerfile omero-web#224 immediately is it still worth splitting dev/devtest into a new repo now, or should we wait?

[joshmoore]

What's the driver for holding off til 6.0.0? Is there a breaking change?

[manics]

IIRC at least one person previously expressed reservations about changing the setup of the Ansible playbook used to build the Dockerfile in case anyone depended on it. I don't hold that view, I think we should treat the documented configuration directories as forming the external contract with downstream images, but document any internal changes. If everyone's agreed with that then once this is reviewed I don't see a blocker to releasing.

Otherwise we can release, but with a non-standard tag to indicate it's a new image.

[snoopycrimecop]

Conflicting PR. Removed from build DOCKER-merge#1629. See the console output for more details.
Possible conflicts:

• Upstream changes
  • requirements.yml

--conflicts