Fix/type mismatch warnings #290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Misiak, Konstanty <[email protected]>
Signed-off-by: Misiak, Konstanty <[email protected]>
Signed-off-by: Misiak, Konstanty <[email protected]> Signed-off-by: Eric Mortensen <[email protected]>
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
marekkozl
previously approved these changes
Sep 3, 2025
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
Related-To: VLCLJ-2555 Signed-off-by: Eric Mortensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-To: VLCLJ-2555
Several hundred type-related warnings appear when compiling the Level-Zero CTS public & embargo code. This leads to important warnings being overlooked because they are buried with the hundreds of type mismatch warnings.
This task will remove these warnings by applying the appropriate type conversions. See comments in the related Jira task for details of some of the fixes.
This PR only fixes those warnings related to mismatched type warnings during comparisons (i.e., "-Wsign-compare" and "-Wnarrowing"). A future PR will fix other warnings (e.g., "-Wunused-variable", "-Wparentheses", "-Wdangling-else", etc.) with the ultimate goal to remove all warnings ("-Wall -Wextra -Wpedantic").
Also, this PR is for the warnings in the public Level-Zero CTS repository. A similar PR will be submitted for the embargo CTS repository components once this PR has been merged.