unify return values for destroy functions #1356
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
Jun 5, 2025
| hPool->ops.finalize(hPool->pool_priv); | ||
| umf_result_t ret = UMF_RESULT_SUCCESS; | ||
| if (hPool->ops.finalize(hPool->pool_priv) != UMF_RESULT_SUCCESS) { | ||
| ret = UMF_RESULT_ERROR_UNKNOWN; |
There was a problem hiding this comment.
why not just pass the result from finalize()?
There was a problem hiding this comment.
I decided to return unknown error when error is not recoverable and pool is corrupted.
There was a problem hiding this comment.
I would return the error code received from ops.finalize() here - like you have done in umfMemoryProviderDestroy()
bratpiorka
reviewed
Jun 5, 2025
| @@ -130,14 +130,15 @@ umf_result_t umfMemspaceNew(umf_memspace_handle_t *hMemspace) { | |||
| return UMF_RESULT_SUCCESS; | |||
| } | |||
|
|
|||
| void umfMemspaceDestroy(umf_memspace_handle_t memspace) { | |||
| umf_result_t umfMemspaceDestroy(umf_memspace_handle_t memspace) { | |||
| assert(memspace); | |||
| for (size_t i = 0; i < memspace->size; i++) { | |||
| umfMemtargetDestroy(memspace->nodes[i]); | |||
There was a problem hiding this comment.
check return val from umfMemtargetDestroy and retrun if if != success
There was a problem hiding this comment.
umfMemtargetDestroy returns void
There was a problem hiding this comment.
according to this PR umfMemtargetDestroy should at least always return SUCCESS, right?
bratpiorka
reviewed
Jun 5, 2025
src/pool/pool_scalable.c
Outdated
| @@ -99,7 +99,7 @@ static const char *tbb_symbol[TBB_POOL_SYMBOLS_MAX] = { | |||
| "?pool_free@rml@@YA_NPEAVMemoryPool@1@PEAX@Z", | |||
| ("?pool_create_v1@rml@@YA?AW4MemPoolError@1@_JPEBUMemPoolPolicy@1@" | |||
| "PEAPEAVMemoryPool@1@@Z"), | |||
| "?pool_destroy@rml@@YA_NPEAVMemoryPool@1@@Z", | |||
| "?/* pool_destroy */@rml@@YA_NPEAVMemoryPool@1@@Z", | |||
bratpiorka
reviewed
Jun 5, 2025
src/provider/provider_file_memory.c
Outdated
| file_memory_provider_t *file_provider = provider; | ||
|
|
||
| uintptr_t key = 0; | ||
| uintptr_t rkey = 0; | ||
| void *rvalue = NULL; | ||
| umf_result_t ret = UMF_RESULT_SUCCESS; | ||
| ; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1217
Description
Checklist