-
Notifications
You must be signed in to change notification settings - Fork 125
Mirror intel/llvm commits #2777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This doesn't affect the `check-unified-runtime-adapter` target, but does fix the main `check-unified-runtime` target.
This list is used in `llvm-lit` to map source configs to their generated versions. This enables the use of `llvm-lit path/to/test/source/file` e.g. `llvm-lit ~/dpcpp/unified-runtime/test/adapters/level_zero/confirm_version.cpp`
A (rather trivial) test has also been added since Offload currently has issues with arguments.
It needs to inherit from ur::handle_base<ur::level_zero::ddi_getter> Previously, only ur_mem_buffer_t inherited from the handle_base which happened to work in most cases as ur_mem_handle_t_ is a variant over few different types, all inheriting from ur_mem_handle_t_.
SYCL allows creating cross-context dependencies. It automatically handles cases where contexts are from different adapters. However, events from a single adapter are always passed directly to urEventWait (even if they are from different contexts). This causes problems with opencl CPU (it returns CL_INVALID_CONTEXT from clWaitForEvents). In general, OpenCL spec does not guarantee that passing events from different contexts works for any function. The same problem exists for all enqueue functions but in practice SYCL does not mix events in the waitList - it will always use urEventWait for synchronization.
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
Automated changes by create-pull-request GitHub action