Mirror intel/llvm commits #2785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to destroy tsan interceptor, this will cause objects leak issue.
The CTS tests for USM uses `EXPECT_SUCCESS` when it should really be `ASSERT_SUCCESS` (the latter returns, which looks to have been the intended behaviour). In addition, some tests have been marked with a new `uur::Offload` known failure, as they cause liboffload to hit an abort.
Firstly, rename `ur_mock_headers` to `ur_mock` as this is a shared library not header only library. Secondly, when part of a subbuild, ensure that the `ur_mock` target depends on the specified `UR_EXTERNAL_DEPENDENCIES`, this is handled by using `add_ur_library()` in place of `add_library()`.
All UR handles should be defined as non-copyable objects. By deleting the copy constructor and assignement operator in `ur::handle_base` we can do this in a centralized location. This should also resolve rule of three violations in adapter handle objects.
Introduce the ability to wrap UR features in pre-processor guards based on the presence of the `guard: NAME` attribute in the yaml specs to support conditionally enabling features.
…8619) Command Buffer, while it is still executing.
Before this PR one thread could add new events to the queue while another removes events, both modifying and potentially corrupting NativeCPU queue::events. This PR adds a mutex to the NativeCPU queue handle to prevent this potential corruption. Aims to at least fix: `SYCL/HostInteropTask/host-task-two-queues.cpp`
github-actions
bot
added
ci/cd
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action