start of llvm/stablehlo bump

[christopherlmunoz]

LLVM 113f01aa82d055410f22a9d03b3468fa68600589
StableHLO 0a4440a5c8de45c4f9649bf3eb4913bf3f97da0d

and fixes protobuf segfault build errors, see onnx issue: (onnx/onnx#7402). pip install onnx==1.17.0 --no-build-isolation

[ 86%] Running C++ protocol buffer compiler on /tmp/pip-install-w8bem1w4/onnx_fd83987e9a6c48a7b68686274e2ab1bb/.setuptools-cmake-build/onnx/onnx-ml.proto
      /tmp/pip-install-w8bem1w4/onnx_fd83987e9a6c48a7b68686274e2ab1bb/.setuptools-cmake-build/tools/protoc-gen-mypy.sh: line 4:  7430 Segmentation fault      (core dumped) "/usr/local/bin/python" -u "$DIR"/protoc-gen-mypy.py
      --mypy_out: protoc-gen-mypy: Plugin failed with status code 139.
      gmake[2]: *** [CMakeFiles/gen_onnx_proto.dir/build.make:74: onnx/onnx-ml.pb.cc] Error 1
      gmake[1]: *** [CMakeFiles/Makefile2:928: CMakeFiles/gen_onnx_proto.dir/all] Error 2

[Sunny-Anand]

Some nits. LGTM

[christopherlmunoz]

Hi @gongsu832, could you please help me debug the s390x absl and protobuf errors? These only started occurring after the merge. Thanks! fyi.. @AlexandreEichenberger

[AlexandreEichenberger]

Here is the errors from the log

/usr/bin/s390x-linux-gnu-ld: CMakeFiles/protoc-gen-upbdefs.dir/src/google/protobuf/generated_message_reflection.cc.o: in function `absl::lts_20240722::Cord const& google::protobuf::Reflection::GetRaw<absl::lts_20240722::Cord const>(google::protobuf::Message const&, google::protobuf::FieldDescriptor const*) const':
generated_message_reflection.cc:(.text._ZNK6google8protobuf10Reflection6GetRawIKN4absl12lts_202407224CordEEERKT_RKNS0_7MessageEPKNS0_15FieldDescriptorE[_ZNK6google8protobuf10Reflection6GetRawIKN4absl12lts_202407224CordEEERKT_RKNS0_7MessageEPKNS0_15FieldDescriptorE]+0xd0): undefined reference to `absl::lts_20240722::log_internal::LogMessageFatal::LogMessageFatal(char const*, int, std::basic_string_view<char, std::char_traits<char> >)'
/usr/bin/s390x-linux-gnu-ld: generated_message_reflection.cc:(.text._ZNK6google8protobuf10Reflection6GetRawIKN4absl12lts_202407224CordEEERKT_RKNS0_7MessageEPKNS0_15FieldDescriptorE[_ZNK6google8protobuf10Reflection6GetRawIKN4absl12lts_202407224CordEEERKT_RKNS0_7MessageEPKNS0_15FieldDescriptorE]+0x11a): undefined reference to `absl::lts_20240722::log_internal::LogMessage::operator<<(std::basic_string_view<char, std::char_traits<char> >)'
/usr/bin/s390x-linux-gnu-ld: generated_message_reflection.cc:(.text._ZNK6google8protobuf10Reflection6GetRawIKN4absl12lts_202407224CordEEERKT_RKNS0_7MessageEPKNS0_15FieldDescriptorE[_ZNK6google8protobuf10Reflection6GetRawIKN4absl12lts_202407224CordEEERKT_RKNS0_7MessageEPKNS0_15FieldDescriptorE]+0x228): undefined reference to `absl::lts_20240722::log_internal::LogMessageFatal::LogMessageFatal(char const*, int, std::basic_string_view<char, std::char_traits<char> >)'
/usr/bin/s390x-linux-gnu-ld: CMakeFiles/protoc-gen-upbdefs.dir/src/google/protobuf/generated_message_reflection.cc.o: in function `absl::lts_20240722::Cord const& google::protobuf::Reflection::GetRawSplit<absl::lts_20240722::Cord const>(google::protobuf::Message const&, google::protobuf::FieldDescriptor const*) const':
generated_message_reflection.cc:(.text._ZNK6google8protobuf10Reflection11GetRawSplitIKN4absl12lts_202407224CordEEERKT_RKNS0_7MessageEPKNS0_15FieldDescriptorE[_ZNK6google8protobuf10Reflection11GetRawSplitIKN4absl12lts_202407224CordEEERKT_RKNS0_7MessageEPKNS0_15FieldDescriptorE]+0x96): undefined reference to `absl::lts_20240722::log_internal::LogMessageFatal::LogMessageFatal(char const*, int, std::basic_string_view<char, std::char_traits<char> >)'

on my Mac, I just had to brew an additional package. @gongsu832 should be able to give you a pointer on how to solve this on s390.

Thanks @christopherlmunoz for doing the update.

[christopherlmunoz]

Can Abseil be installed on the s390x test instance? I believe since this is the first LLVM bump .buildbot/jenkins-build-llvm-project.py and docker/Dockerfile.llvm-project are being used. I don't know if they were tested on s390x prior to the #3275 PR.

[christopherlmunoz]

@jenkins-droid test this please

[Sunny-Anand]

@jenkins-droid test this please

[christopherlmunoz]

Hi @AlexandreEichenberger and @gongsu832, Separate onnx/protobuf issue. All PRs are now failing on s390x because pip install onnx==1.17.0 is failing. Third-party/onnx installs the latest protobuf, which is v33 and was released yesterday.

[christopherlmunoz]

@jenkins-droid test this please

[tungld]

@jenkins-droid test this please

[tungld]

@jenkins-droid test this please

[AlexandreEichenberger]

LGTM,

There seems to be lots of extract / insert vector operations around the onnx.round operations; this will need a separate investigation to see if they can be avoided.

[jenkins-droid]

Jenkins Linux s390x Build #17566 [push] start of llvm/stablehlo ... started at 10:37

[jenkins-droid]

Jenkins Linux amd64 Build #17564 [push] start of llvm/stablehlo ... started at 09:37

[jenkins-droid]

Jenkins Linux s390x Build #17566 [push] start of llvm/stablehlo ... failed after 6 min 16 sec

[jenkins-droid]

Jenkins Linux amd64 Build #17564 [push] start of llvm/stablehlo ... failed after 7 min 0 sec