Open
Conversation
Signed-off-by: Tong Chen <chentong@us.ibm.com>
chentong319
changed the title
chentong319
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing problems:
For the first problem, it is caused by the incorrect way to use the Passes.td. The table gen generated createInstrumentPass, but we implemented that function again.
For the second problem, we include Pass/Passes.h.inc directly in Passes.hpp. The Passes.h.inc depends on OMPassTransformGen. We did not specify this dependency for all files that include Passes.hpp. I found that we unnecessarily include Passes.hpp in may files.
This PR focused only on BufferOMPLoopHoisting. If the new approach is approved, we will have another PR for other passes.