[WIP DNM] stop using zeDevicePciGetPropertiesExt()#699
Open
bgoglin wants to merge 7 commits intoopen-mpi:masterfrom
Open
[WIP DNM] stop using zeDevicePciGetPropertiesExt()#699bgoglin wants to merge 7 commits intoopen-mpi:masterfrom
bgoglin wants to merge 7 commits intoopen-mpi:masterfrom
Conversation
Didn't seem to break anything so far. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
ZE and ZES may return devices in different orders. open-mpi#595 (comment) Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Refs open-mpi#698 Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Now that zesInit() is mandatory, don't bother falling back to the core API, Sysman shouldn't fail. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
We don't need it anymore. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Now that zesInit() is mandatory, don't bother trying the core API extension first in case sysman wouldn't be available. Hence remove the zeDevicePciGetPropertiesExt() optional detection Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge for now, zesDevicePciGetProperties() doesn't report PCI link speed as expected. Waiting for intel/compute-runtime#778