Bring better Fortran TKR support in 4.1 #13245
Conversation
as reported in open-mpi#12506, upcoming LLVM 19 can generate some false positive that will make the mpi Fortran modules unusable. Harden the test by using a module in order to fix that. Thanks Paul Osmialowski for bringing this to our attention. Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 8c601e1)
Try the !DIR$ IGNORE_TKR directive and the type(*) type in order to support upcoming LLVM 19 flang compiler. Thanks Paul Osmialowski for the report and suggesting the solution. Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 0bc995f)
LLVM 18 supports the ASYNCHRONOUS keyword in an interface, but not in a subroutine (!) so test both in order to avoid a false positive that will lead to compilation failure. Signed-off-by: Gilles Gouaillardet <[email protected]>
NVIDIA HPC Compiler (e.g. nvfortran) incorrectly selected the GCC style pragmas to support IGNORE_TKR. Harden the test by mimicking exactly the mpi f08 bindings in order to fix that false positive. Thanks Chris Parrot for the report. Refs. open-mpi#11582 Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 600df6a)
Signed-off-by: George Bosilca <[email protected]>
|
bot:retest |
|
There's a legit Is there a reason to bring this back to v4.1.x? We're not planning on any future 4.1.x releases unless we really, really need to. |
|
I don't understand how this works on main and 5.0 but not on the 4.1 ! The root issue is that one of the files generated during configure, the I see in the configure script that we remove all |
This PR updates the 4.1 with #12512 and some parts of 30eb36f and b6017d2.
bot:notacherrypick