Open
Conversation
mpagot
force-pushed
the
pyproject_validate
branch
from
feb4705 to
5808a27
Compare
okurz
requested changes
Oct 30, 2025
Comment on lines
24
to
+29
| .PHONY: checkstyle | ||
| checkstyle: ruff | ||
|
|
||
| .PHONY: checkpyproject | ||
| checkpyproject: validate-pyproject pyproject.toml | ||
|
|
Member
There was a problem hiding this comment.
I don't think this can work. Did you test this? This should probably be
Suggested change
| .PHONY: checkstyle | |
| checkstyle: ruff | |
| .PHONY: checkpyproject | |
| checkpyproject: validate-pyproject pyproject.toml | |
| .PHONY: checkpyproject | |
| checkpyproject: | |
| validate-pyproject pyproject.toml | |
| .PHONY: checkstyle | |
| checkstyle: ruff checkpyproject |
and probably we should change the github CI instructions to just call make checkstyle instead of individually mention all checks
Validate the file using validate-pyproject Add the test as part of the main `test` target. Add a workflow step to run the test.
mpagot
force-pushed
the
pyproject_validate
branch
from
5808a27 to
be1df92
Compare
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the file using validate-pyproject
Ticket: https://progress.opensuse.org/issues/191328