PART 3: refactor: move static methods to free functions - After #429+#430#432
Draft
okurz wants to merge 1 commit intoopenSUSE:masterfrom
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 91 91
Lines 8614 8600 -14
Branches 460 460
=========================================
- Hits 8614 8600 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
okurz
changed the title
okurz
changed the title
okurz
changed the title
okurz
force-pushed
the
feature/033_improve_code_quality_remove_all_staticmethods
branch
3 times, most recently
from
8d7441b to
5903fda
Compare
okurz
force-pushed
the
feature/033_improve_code_quality_remove_all_staticmethods
branch
from
5903fda to
dc9a576
Compare
okurz
force-pushed
the
feature/033_improve_code_quality_remove_all_staticmethods
branch
from
dc9a576 to
149855c
Compare
Motivation: Adhere to project guidelines to prioritize functional style over Object-Oriented and address reviewer feedback. Design Choices: - Extracted logic from @staticmethod methods into module-level functions. - Kept original method names as minimal wrappers where necessary for backward compatibility and test stability. - Updated tests to use module-level patching instead of patch.object where appropriate. User Benefits: - Improved code maintainability through explicit data flow. - Enhanced testability by allowing logic to be verified in isolation. - Cleaner class definitions focused on state management.
okurz
force-pushed
the
feature/033_improve_code_quality_remove_all_staticmethods
branch
from
149855c to
ee524e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: Adhere to project guidelines to prioritize functional style
over Object-Oriented and address reviewer feedback.
Design Choices:
backward compatibility and test stability.
appropriate.
User Benefits:
After: