fix: ignore development job groups in openQA overview links#442
Merged
mergify[bot] merged 2 commits intoopenSUSE:masterfrom Mar 18, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 94 94
Lines 8942 8954 +12
Branches 462 462
=========================================
+ Hits 8942 8954 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asmorodskyi
reviewed
Mar 15, 2026
okurz
added a commit
to okurz/qem-bot
that referenced
this pull request
Mar 15, 2026
Motivation: Avoid "if not" pattern in ternary assignment to reduce cognitive load, as suggested in PR openSUSE#442 review. Design Choices: Swapped the ternary order to use a positive condition. User Benefits: Better code maintainability. Related issue: openSUSE#442
okurz
added a commit
to okurz/qem-bot
that referenced
this pull request
Mar 17, 2026
Motivation: Avoid "if not" pattern in ternary assignment to reduce cognitive load, as suggested in PR openSUSE#442 review. Design Choices: Swapped the ternary order to use a positive condition. User Benefits: Better code maintainability. Related issue: openSUSE#442
okurz
force-pushed
the
feature/038_poo197897_ignore_devel_groups_in_posted_comments
branch
from
7a1879c to
a811c1c
Compare
Motivation: qem-bot ignores development and test job groups during approval logic. However, the openQA overview links (and badges) in posted comments included all jobs, which led to confusion when links showed failures in ignored groups. Design Choices: - Appended ¬_group_glob=*Devel*%2C*Test* to openQA overview and badge URLs in openqabot/commenter.py. - Made this conditional on config.settings.allow_development_groups being unset, matching the internal logic in openqabot/openqa.py. - Updated tests to verify the URL parameter's presence/absence based on configuration. User Benefits: Users will now see openQA overview links in comments that accurately reflect the set of jobs considered by qem-bot for approval, reducing confusion about "ignored" failures. Related progress issue: https://progress.opensuse.org/issues/197897
Motivation: Avoid "if not" pattern in ternary assignment to reduce cognitive load, as suggested in PR openSUSE#442 review. Design Choices: Swapped the ternary order to use a positive condition. User Benefits: Better code maintainability. Related issue: openSUSE#442
okurz
force-pushed
the
feature/038_poo197897_ignore_devel_groups_in_posted_comments
branch
from
a811c1c to
9a1a3ed
Compare
gauravpathak
approved these changes
Mar 18, 2026
Wabri
approved these changes
Mar 18, 2026
Contributor
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
okurz
deleted the
feature/038_poo197897_ignore_devel_groups_in_posted_comments
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
qem-bot ignores development and test job groups during approval logic. However,
the openQA overview links (and badges) in posted comments included all jobs,
which led to confusion when links showed failures in ignored groups.
Design Choices:
in openqabot/commenter.py.
unset, matching the internal logic in openqabot/openqa.py.
configuration.
User Benefits:
Users will now see openQA overview links in comments that accurately reflect
the set of jobs considered by qem-bot for approval, reducing confusion about
"ignored" failures.
Related progress issue: https://progress.opensuse.org/issues/197897