fix bugs in the smt cannonicalazion passes for sdiv and srem #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are few bugs in
SRemFold
andSDivFold
.When the canonicalizer sees constants as operands for the SRem and SDiv operations, it tries to elide the instruction and instead just return the new constant itself, unfortunatly on the edge cases it doesn't actually match z3's semantics.
For SRem when the rhs is 0 then the result should always be the lhs.
For SDiv when there's an underflow it should return INT_MIN, and when there's a div by zero the result should either be one or neg one, depending on sign of lhs
I also took the liberty of adding passes for Udiv and URem.
Not sure if there are unit tests for this part of the codebase, but if so I'd like to add some if I could, just to be extra sure of everything