mcc: add SpyderChecker 24/48 - support and tests#4072
Open
AYELET0527661122 wants to merge 6 commits intoopencv:4.xfrom
Open
mcc: add SpyderChecker 24/48 - support and tests#4072AYELET0527661122 wants to merge 6 commits intoopencv:4.xfrom
AYELET0527661122 wants to merge 6 commits intoopencv:4.xfrom
Conversation
Adds chart definitions and unit tests for 24/48 color variants. Depends on opencv/opencv_extra#1316 for test images.
Defining the new color palettes
Added color data and geometry for CSpyder48.
Removed unnecessary iostream include comment.
|
|
Could you specify in the description where did you get the values from, which you add in dictionary.hpp ? |
|
|
||
| #include "checker_model.hpp" | ||
| #include "dictionary.hpp" | ||
|
|
There was a problem hiding this comment.
nit: imo, the empty line was good here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3935
This PR adds support for Datacolor SpyderChecker v2 color charts
with 24 and 48 patches to the MCC module.
Changes include:
Test images are provided in opencv_extra.
Depends on opencv/opencv_extra#1316
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.