Skip to content

mcc: add SpyderChecker 24/48 - support and tests#4072

Open
AYELET0527661122 wants to merge 6 commits intoopencv:4.xfrom
AYELET0527661122:mcc-Spyder48-Spyder24-fix
Open

mcc: add SpyderChecker 24/48 - support and tests#4072
AYELET0527661122 wants to merge 6 commits intoopencv:4.xfrom
AYELET0527661122:mcc-Spyder48-Spyder24-fix

Conversation

@AYELET0527661122
Copy link

@AYELET0527661122 AYELET0527661122 commented Feb 2, 2026

Resolves #3935
This PR adds support for Datacolor SpyderChecker v2 color charts
with 24 and 48 patches to the MCC module.

Changes include:

  • Added new checker models for SpyderChecker 24 and 48
  • Define color and geometry constants
  • Added unit tests for detection and drawing

Test images are provided in opencv_extra.

Depends on opencv/opencv_extra#1316

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Adds chart definitions and unit tests for 24/48 color variants.
Depends on opencv/opencv_extra#1316 for test images.
Defining the new color palettes
Added color data and geometry for CSpyder48.
Removed unnecessary iostream include comment.
@AlexanderHaritonov
Copy link

AlexanderHaritonov commented Feb 3, 2026

This release adds support for Datacolor SpyderChecker v2 color charts
with 24 and 48 fixes to the MCC module.
I assume this is a bad translation, probably you mean "PR" instead "release" and "patches" instead "fixes"?
Also you should in the summary reference the issue you are addressing (#3935). Write "Resolves #3935" and it should be linked to the issue.

@AlexanderHaritonov
Copy link

Could you specify in the description where did you get the values from, which you add in dictionary.hpp ?


#include "checker_model.hpp"
#include "dictionary.hpp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: imo, the empty line was good here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCC module: Add support for Datacolor SpyderCheckr

2 participants