Skip to content

Fix reg shift python sample#4073

Open
shiffiH wants to merge 2 commits intoopencv:4.xfrom
shiffiH:fix-reg-shift-python-sample
Open

Fix reg shift python sample#4073
shiffiH wants to merge 2 commits intoopencv:4.xfrom
shiffiH:fix-reg-shift-python-sample

Conversation

@shiffiH
Copy link

@shiffiH shiffiH commented Feb 4, 2026

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@shiffiH shiffiH marked this pull request as draft February 4, 2026 10:33
@shiffiH
Copy link
Author

shiffiH commented Feb 4, 2026

This PR fixes the Python sample modules/reg/samples/reg_shift.py by:

  • Preferring the canonical cv.reg.* API, with a fallback to underscore-style bindings for older versions.
  • Avoiding nested mapper construction, which was reported to cause segfaults.

Fixes #1935

@shiffiH shiffiH marked this pull request as ready for review February 4, 2026 10:58
@shiffiH
Copy link
Author

shiffiH commented Feb 4, 2026

Hi, this PR is ready for review. CI is currently awaiting approval to run workflows for the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant