fix: Modify After a block is deleted from a group, data is not updated.

[xuanlid]

data is updated

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Bug Fixes
  • Improved synchronization of group block lists after fetching blocks for a specific group, ensuring the displayed group information is always up-to-date.

[coderabbitai]

Walkthrough

The code update enhances the BlockPanel.vue component by extending the useBlock composable to include getGroupList and setGroupList. The fetchBlocks function now updates the relevant group's blocks property in the global group list after fetching data, ensuring the state stays synchronized.

Changes

File(s)	Change Summary
packages/plugins/materials/src/meta/block/src/BlockPanel.vue	Extended useBlock usage; updated fetchBlocks to synchronize group's blocks in global list

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BlockPanel
    participant useBlock

    User->>BlockPanel: Triggers fetchBlocks
    BlockPanel->>useBlock: fetchBlocks(groupId)
    useBlock-->>BlockPanel: Returns data
    BlockPanel->>useBlock: getGroupList()
    useBlock-->>BlockPanel: Returns groupList
    BlockPanel->>BlockPanel: Update blocks for groupId in groupList
    BlockPanel->>useBlock: setGroupList(updatedGroupList)

Loading

Poem

In the garden of blocks, a change took root,
Groups now refreshed with data to boot.
With a hop and a sync, the lists align,
Each bunny dev grins—"That code looks fine!"
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4bd9faa and 28e7c7d.

📒 Files selected for processing (1)

• packages/plugins/materials/src/meta/block/src/BlockPanel.vue (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: gene9831
PR: opentiny/tiny-engine#1041
File: packages/plugins/datasource/src/DataSourceList.vue:138-138
Timestamp: 2025-01-14T10:06:25.508Z
Learning: PR #1041 in opentiny/tiny-engine is specifically for reverting Prettier v3 formatting to v2, without any logical code changes or syntax improvements.

Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/RenderMain.ts:82-88
Timestamp: 2025-01-14T08:50:50.226Z
Learning: For PR #1011, the focus is on resolving conflicts and migrating code, with architectural improvements deferred for future PRs.

packages/plugins/materials/src/meta/block/src/BlockPanel.vue (2)

Learnt from: chilingling
PR: opentiny/tiny-engine#1389
File: docs/api/frontend-api/material-api.md:84-117
Timestamp: 2025-05-13T06:27:51.334Z
Learning: The `registerBlock` method in the `useMaterial` API is planned for deprecation and should not be documented or recommended.

Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/material-function/material-getter.ts:55-88
Timestamp: 2025-01-14T04:25:08.323Z
Learning: The BlockLoadError component in packages/canvas/render/src/material-function/material-getter.ts requires a `name` prop to display which block failed to load.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: push-check

🔇 Additional comments (2)

packages/plugins/materials/src/meta/block/src/BlockPanel.vue (2)

49-50: LGTM: Properly extending useBlock composable

The addition of getGroupList and setGroupList to the destructured return from useBlock() is necessary for the state synchronization logic implemented below.

---

115-121: LGTM: Effective fix for data synchronization issue

This change addresses the PR objective by ensuring the global group list stays synchronized with the fetched block data. When blocks are deleted from a group, the next fetch will retrieve the updated list and now properly update the global state.

The implementation is solid:

• Uses optional chaining to handle potential null/undefined from getGroupList()
• Only updates the matching group by ID, leaving others unchanged
• Executes only on successful fetch (inside .then() block)
• Applies only to user-defined groups (not default/all groups)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.