-
Notifications
You must be signed in to change notification settings - Fork 408
fix: url with blockId will get empty page list #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: url with blockId will get empty page list #1542
Conversation
WalkthroughThe Changes
Estimated code review effort1 (~3 minutes) Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
【问题描述】
url 使用区块 id 进入应用时(如:
http://localhost:8090/?type=app&id=1&tenant=1&blockid=1
),打开页面管理插件,页面管理插件页面列表为空。【问题分析】
页面管理插件页面列表的数据依赖初始化页面 pageid 得到的列表。如果初始化进来时 blockid,则得不到页面列表,最终导致 bug。
【解决方案】
在
onMounted
钩子中,增加调用refreshPageList
方法。What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit