Skip to content

fix: url with blockId will get empty page list #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025

Conversation

chilingling
Copy link
Member

@chilingling chilingling commented Jul 22, 2025

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

【问题描述】

url 使用区块 id 进入应用时(如:http://localhost:8090/?type=app&id=1&tenant=1&blockid=1 ),打开页面管理插件,页面管理插件页面列表为空。

【问题分析】

页面管理插件页面列表的数据依赖初始化页面 pageid 得到的列表。如果初始化进来时 blockid,则得不到页面列表,最终导致 bug。

【解决方案】

onMounted 钩子中,增加调用 refreshPageList 方法。

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Bug Fixes
    • Improved the initial loading of the page list, ensuring it refreshes automatically when the component mounts.

Copy link
Contributor

coderabbitai bot commented Jul 22, 2025

Walkthrough

The refreshPageList function in PageTree.vue was repositioned to appear before the onMounted hook, and a call to refreshPageList(getAppId()) was added within onMounted to ensure the page list is refreshed when the component mounts. Additionally, the TreeNode interface in Tree.vue was changed from a non-exported to an exported interface. No other logic or function signatures were changed.

Changes

File Change Summary
packages/plugins/page/src/PageTree.vue Moved refreshPageList before onMounted; called it in onMounted
packages/plugins/page/src/Tree.vue Made TreeNode interface exported

Estimated code review effort

1 (~3 minutes)

Poem

A hop, a skip, a Vue refresh,
The page list loads anew, so fresh!
With code in order, neat and spry,
The rabbit nods as pages fly.
On mount we leap, no time to lag,
Another win—let’s wave the flag! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4e6fc9 and 7659510.

📒 Files selected for processing (2)
  • packages/plugins/page/src/PageTree.vue (1 hunks)
  • packages/plugins/page/src/Tree.vue (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/plugins/page/src/Tree.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/plugins/page/src/PageTree.vue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Jul 22, 2025
@hexqi hexqi merged commit c157e9f into opentiny:develop Jul 24, 2025
2 checks passed
chilingling added a commit to chilingling/tiny-engine that referenced this pull request Jul 24, 2025
chilingling added a commit to chilingling/tiny-engine that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants