Replace HloSharding::maximal_ with single_device_.#38253
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 25, 2026
Merged
Replace HloSharding::maximal_ with single_device_.#38253copybara-service[bot] merged 1 commit intomainfrom
HloSharding::maximal_ with single_device_.#38253copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_874828161
branch
2 times, most recently
from
e5e5a3d to
2e1afba
Compare
Before this cl, `maximal_` is true if replicated or single_device. With this cl, we remove `maximal_`. Instead, we use `single_device_` to indicate if the tensor is on a single device. PiperOrigin-RevId: 874892477
copybara-service
bot
force-pushed
the
test_874828161
branch
from
2e1afba to
63013d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
HloSharding::maximal_withsingle_device_.Before this cl,
maximal_is true if replicated or single_device. With this cl, we removemaximal_. Instead, we usesingle_device_to indicate if the tensor is on a single device.