ZVOL: Return early, if volmode is ZFS_VOLMODE_NONE on FreeBSD side #17405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
amotin
reviewed
May 30, 2025
amotin
added
the
Status: Revision Needed
Return from zvol_os_create_minor() function immediatly after dsl_prop_get_integer() call if volmode property value is set to 'none', like it is doing on Linux side. Sponsored-by: vStack, Inc. Signed-off-by: Fedor Uporov <[email protected]>
fuporovvStack
force-pushed
the
zvol-small-compatibility-fixes-return-create-minor-early
branch
from
b0a712a to
fba3938
Compare
|
I've apdated the PR according your suggestions, if I got it clearly. Also, as alternative, opened another PR, where zvol_alloc() function is implemented, like it is done on Linux side: |
amotin
removed
the
Status: Revision Needed
amotin
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Return early, if volmode is ZFS_VOLMODE_NONE on FreeBSD side
Description
Return from zvol_os_create_minor() function immediatly after dsl_prop_get_integer() call if volmode property value is 'none',
like it is doing on Linux side. The error value EAGAIN is returned in this case on both platforms.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.