Skip to content

Missing tests in make pkg #17491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Missing tests in make pkg #17491

merged 1 commit into from
Jun 30, 2025

Conversation

tuxoko
Copy link
Contributor

@tuxoko tuxoko commented Jun 27, 2025

Motivation and Context

Warning: TestGroup '/var/tmp/tests/functional/ctime' not added to this run. Auxiliary script '/var/tmp/tests/functional/ctime/setup' failed verification.

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Copy link
Member

amotin commented Jun 27, 2025

@tuxoko

error: commit message body contains line over 72 characters

```
Warning: TestGroup '/var/tmp/tests/functional/ctime' not added to this
run. Auxiliary script '/var/tmp/tests/functional/ctime/setup' failed
verification.
```

Signed-off-by: Chunwei Chen <[email protected]>
@tuxoko
Copy link
Contributor Author

tuxoko commented Jun 27, 2025

error: commit message body contains line over 72 characters

Fixed

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Jun 27, 2025
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually make sense, but I am not so deep there.

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've missed this a couple of times now. It probably makes sense to add an option the CI can set to convert these warnings to fatal errors.

@behlendorf behlendorf merged commit eacf618 into openzfs:master Jun 30, 2025
36 of 37 checks passed
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants