Skip to content

tidy: Enforce blank lines before subs #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025

Conversation

perlpunk
Copy link
Contributor

For that I had to remove --fbl, but added --keep-old-blank-lines and --noblanks-before-blocks

I used the modern package ... { syntax because it also adds blank lines before packages.

Also it adds blank lines before pod

Motivation: mostly because I was annoyed by missing blank lines between pod and subs

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (12f3e8e) to head (0d48285).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6398   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         399      399           
  Lines       40717    40723    +6     
=======================================
+ Hits        40358    40364    +6     
  Misses        359      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but missing coverage

@b10n1k
Copy link
Contributor

b10n1k commented Apr 23, 2025

I prefer this format more. I will approve once is mark ready for review

This comment was marked as resolved.

This comment was marked as resolved.

For that I had to remove --fbl, but added --keep-old-blank-lines and
--noblanks-before-blocks

I used the modern `package ... {` syntax because it also adds blank lines
before packages.

Also it adds blank lines before pod
@perlpunk perlpunk marked this pull request as ready for review July 19, 2025 00:16
@perlpunk
Copy link
Contributor Author

Coverage fixed

@mergify mergify bot merged commit 37380d0 into os-autoinst:master Jul 20, 2025
46 checks passed
@perlpunk perlpunk deleted the tidy-blank-sub branch July 20, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants