-
Notifications
You must be signed in to change notification settings - Fork 217
Add link to Helm in README #6583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
container/helm/README.md
Outdated
|
||
``` | ||
kubectl get pods [--all-namespaces] | ||
kubectl get pods -n ingress-nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the namespace ingress-nginx
? Where is it used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is the default nemaspace for ingress. and it is where the ingress controller runs and handles the routing to the services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that depends on:
- what type of ingress to you have (if any)
- what type of kubernetes distribution do you have
- your settings
I do not think there is a sensible default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you can resolve this as well with the change from #6583 (comment)
container/helm/README.md
Outdated
For testing, it is also useful to create a my_values.yaml and run | ||
|
||
``` | ||
helm install openqa helm/charts/openqa/ -f my-values.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either my_values.yaml
or my-values.yaml
but not both.
container/helm/README.md
Outdated
archives and rerun `helm dependency update charts/openqa/`. | ||
|
||
|
||
Check that everything is up and running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't helm list
or helm status
be better suited to get the required information about the helm deployment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, it can be used as well. but kubectl will show the pods names where the helm I think lists the running services. Would you like to extend the text to include those too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use helm status --show-resources
, you will see all the resources (i.e. including pods, deployments, services).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
researched and updated. helm status --show-resources
is it.
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6583 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 399 399
Lines 40717 40717
=======================================
Hits 40358 40358
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't omit punctuation when writing documentation.
container/helm/README.md
Outdated
|
||
Check that everything is up and running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check that everything is up and running | |
Check that everything is up and running: |
container/helm/README.md
Outdated
|
||
## Configuration | ||
|
||
It might be necessary to customize the charts by overriding some of the | ||
variables inside _charts/values.yaml_ to suit your needs. | ||
|
||
For testing, it is also useful to create a my_values.yaml and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing, it is also useful to create a my_values.yaml and run | |
For testing, it is also useful to create a `my_values.yaml` and run: |
A link to the helm's README added besides some extensions in its guides and the steps which likely needs for getting started with the charts. poo: https://progress.opensuse.org/issues/183608 Signed-off-by: Ioannis Bonatakis <[email protected]>
commit 12f3e8e Merge: a61b311 febd545 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Wed Jul 16 18:36:22 2025 +0000 Commit: GitHub <[email protected]> CommitDate: Wed Jul 16 18:36:22 2025 +0000 Merge pull request os-autoinst#6583 from b10n1k/helm_docs Add link to Helm in README
A link to the helm's README added besides some extensions in its guides and the steps which likely needs for getting started with the charts.
poo: https://progress.opensuse.org/issues/183608