Skip to content

fix(worker): reject jobs explicitly when worker is stopping#6990

Merged
mergify[bot] merged 1 commit intoos-autoinst:masterfrom
okurz:fix/43_scheduling_scalability
Feb 13, 2026
Merged

fix(worker): reject jobs explicitly when worker is stopping#6990
mergify[bot] merged 1 commit intoos-autoinst:masterfrom
okurz:fix/43_scheduling_scalability

Conversation

@okurz
Copy link
Member

@okurz okurz commented Feb 9, 2026

Workers previously ignored new job assignments while finishing a previous job,
leading to stuck "assigned" jobs in the database.

Note that "$worker->is_stopping" is not a guarantee that the worker will
accomplish to stop. It just means that the current job is stopping.

This change ensures workers send a "rejected" message when in the "stopping"
state. Additionally, t/43-scheduling-and-worker-scalability.t is robustified to
handle rescheduled jobs during polling.

Fixes sporadic failures in t/43-scheduling-and-worker-scalability.t.

Related progress issue: https://progress.opensuse.org/issues/196295

@okurz okurz force-pushed the fix/43_scheduling_scalability branch from 6afb0de to 4596c76 Compare February 9, 2026 20:20
@okurz okurz marked this pull request as draft February 9, 2026 20:42
@okurz okurz force-pushed the fix/43_scheduling_scalability branch from 4596c76 to 3de0243 Compare February 10, 2026 09:51
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.58%. Comparing base (ba6a266) to head (ba40034).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6990   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         416      416           
  Lines       42524    42524           
=======================================
  Hits        42347    42347           
  Misses        177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@okurz okurz force-pushed the fix/43_scheduling_scalability branch from 3de0243 to b08f6ae Compare February 12, 2026 19:13
@okurz okurz changed the title test: fix sporadic failure in 43-scheduling-and-worker-scalability.t fix(worker): reject jobs explicitly when worker is stopping Feb 12, 2026
@okurz okurz marked this pull request as ready for review February 12, 2026 19:14
Workers previously ignored new job assignments while finishing a previous job,
leading to stuck "assigned" jobs in the database.

Note that "$worker->is_stopping" is not a guarantee that the worker will
accomplish to stop. It just means that the current job is stopping.

This change ensures workers send a "rejected" message when in the "stopping"
state. Additionally, t/43-scheduling-and-worker-scalability.t is robustified to
handle rescheduled jobs during polling.

Fixes sporadic failures in t/43-scheduling-and-worker-scalability.t.
@okurz okurz force-pushed the fix/43_scheduling_scalability branch from b08f6ae to ba40034 Compare February 13, 2026 09:56
@mergify mergify bot merged commit 9c7f0e6 into os-autoinst:master Feb 13, 2026
51 checks passed
@okurz okurz deleted the fix/43_scheduling_scalability branch February 16, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants