fix(worker): reject jobs explicitly when worker is stopping#6990
Merged
mergify[bot] merged 1 commit intoos-autoinst:masterfrom Feb 13, 2026
Merged
fix(worker): reject jobs explicitly when worker is stopping#6990mergify[bot] merged 1 commit intoos-autoinst:masterfrom
mergify[bot] merged 1 commit intoos-autoinst:masterfrom
Conversation
6afb0de to
4596c76
Compare
okurz
commented
Feb 10, 2026
4596c76 to
3de0243
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6990 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 416 416
Lines 42524 42524
=======================================
Hits 42347 42347
Misses 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3de0243 to
b08f6ae
Compare
d3flex
reviewed
Feb 13, 2026
Workers previously ignored new job assignments while finishing a previous job, leading to stuck "assigned" jobs in the database. Note that "$worker->is_stopping" is not a guarantee that the worker will accomplish to stop. It just means that the current job is stopping. This change ensures workers send a "rejected" message when in the "stopping" state. Additionally, t/43-scheduling-and-worker-scalability.t is robustified to handle rescheduled jobs during polling. Fixes sporadic failures in t/43-scheduling-and-worker-scalability.t.
b08f6ae to
ba40034
Compare
Martchus
approved these changes
Feb 13, 2026
d3flex
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workers previously ignored new job assignments while finishing a previous job,
leading to stuck "assigned" jobs in the database.
Note that "$worker->is_stopping" is not a guarantee that the worker will
accomplish to stop. It just means that the current job is stopping.
This change ensures workers send a "rejected" message when in the "stopping"
state. Additionally, t/43-scheduling-and-worker-scalability.t is robustified to
handle rescheduled jobs during polling.
Fixes sporadic failures in t/43-scheduling-and-worker-scalability.t.
Related progress issue: https://progress.opensuse.org/issues/196295