Skip to content

Conversation

d3flex
Copy link
Contributor

@d3flex d3flex commented Mar 13, 2025

No description provided.

@okurz
Copy link
Member

okurz commented Mar 14, 2025

Why?

@d3flex
Copy link
Contributor Author

d3flex commented Mar 14, 2025

Why?

it is quite faster. I guess that will be enabled by default in the future and we cant revert these changes.

@kalikiana
Copy link
Member

Why?

it is quite faster. I guess that will be enabled by default in the future and we cant revert these changes.

I would suggest mentioning your motivation in the description. Everyone may not have read the announcement on [email protected]. That said, you have my vote.

@d3flex d3flex force-pushed the feature/zypp_env branch from d4f8ab3 to 398dccd Compare March 14, 2025 11:19
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit messages has grammar mistakes and most importantly states that this enables parallel installation (but in reality this change enables parallel downloads).

@d3flex d3flex force-pushed the feature/zypp_env branch from 398dccd to 3da1ae1 Compare March 17, 2025 11:47
@Martchus
Copy link
Contributor

Martchus commented Mar 17, 2025

I see that you've just updated the commit but the commit message still says "parallel installation". This is wrong. The feature enable here will only enable parallel downloads. And "We might expect some that it works …" still sounds wrong.

I would word it this way:

Enable parallel downloads during package installation

Use ZYPP_PCK_PRELOAD=1 to enable parallel downloads during package installations
to make it faster. Note that this is still an experimental feature.

Use ZYPP_PCK_PRELOAD=1 to enable parallel downloads during package installations
to make it faster. Note that this is still an experimental feature.
@d3flex d3flex force-pushed the feature/zypp_env branch from 3da1ae1 to 482d33b Compare March 18, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants