Prevent worker to fail on missing key and secret keys #248
Conversation
tests/containers/worker.pm
Outdated
| assert_script_run("docker run -d --network testing $volumes --name openqa_worker openqa_worker"); | ||
| my $expected_log = 'Failed to register'; | ||
| wait_for_container_log('openqa_worker', 'Failed to register', 'docker'); | ||
| record_soft_failure("$expected_log - https://progress.opensuse.org/issues/186651"); |
There was a problem hiding this comment.
Why do we need a soft fail? If you're adding valid API credentials to the config, this should work.
There was a problem hiding this comment.
And please only use softfail references with product issues, not progress tickets.
There was a problem hiding this comment.
Why do we need a soft fail? If you're adding valid API credentials to the config, this should work.
The idea was to let a green test, but somehow make visible that this is not functional, so it wont be ignored. As it was the case so far and surprised us when we found out.
The problem is not about the keys anymore. I didnt look at it since I pushed the draft, but i think it is related to the containers issue and the proxy setup or something. please try out and I would be glad to sit down together on Monday if you want.
And please only use softfail references with product issues, not progress tickets.
I dont know if you have the context. the test is passing while the worker module is never connecting to the server. For various reasons but also by design from my POV. I am looking for ideas. would just a record_info enough? the test will still shown as passed. not sure if I am clear or I need to say more. In any case this is a draft, and I dont know what would be, even we had discussed it in the team
The worker still fails but not due to misconfuration. But this time will throw an additional soft fail to make visible the issue with the containers' communication. poo: https://progress.opensuse.org/issues/186651 Signed-off-by: Ioannis Bonatakis <[email protected]>
d3flex
force-pushed
the
feat/test_reg_worker
branch
from
ac668b3 to
e1eded8
Compare
The worker still fails but not due to misconfuration. But this time will throw an additional soft fail to make visible the issue with the containers' communication.
poo: https://progress.opensuse.org/issues/186651