Skip to content

Enable SaltBundle on SLES12-SP5#22704

Merged
grisu48 merged 1 commit intoos-autoinst:masterfrom
asmorodskyi:saltbundle
Aug 7, 2025
Merged

Enable SaltBundle on SLES12-SP5#22704
grisu48 merged 1 commit intoos-autoinst:masterfrom
asmorodskyi:saltbundle

Conversation

@asmorodskyi
Copy link
Member

@asmorodskyi asmorodskyi commented Jul 18, 2025 •
edited
Loading

ricardobranco777
ricardobranco777 reviewed Jul 18, 2025
View reviewed changes
mloviska
mloviska reviewed Jul 18, 2025
View reviewed changes
okurz
okurz requested changes Jul 18, 2025
View reviewed changes
okurz
okurz approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The still open point would be https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/22704/files#r2216108721 which you disagree with. Besides that there are no other functional concerns.

grisu48
grisu48 reviewed Aug 4, 2025
View reviewed changes
grisu48
grisu48 approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@grisu48 grisu48 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once we have all needed VRs.

@grisu48
Copy link
Contributor

grisu48 commented Aug 6, 2025

VRs for SLES15 are still missing.

@asmorodskyi
Copy link
Member Author

asmorodskyi commented Aug 6, 2025

VRs for SLES15 are still missing.

VRs for SLE 15 SP3 have been added

@grisu48
Copy link
Contributor

grisu48 commented Aug 6, 2025

VRs for SLES15 are still missing.

VRs for SLE 15 SP3 have been added

Failing: https://openqa.suse.de/tests/18685125#step/bci_test_docker/19

@asmorodskyi
Copy link
Member Author

asmorodskyi commented Aug 6, 2025

VRs for SLES15 are still missing.

VRs for SLE 15 SP3 have been added

Failing: https://openqa.suse.de/tests/18685125#step/bci_test_docker/19

yeah I have missed declare function import , done , branch updated new VR is running http://openqa.suse.de/tests/18688576

@asmorodskyi
Copy link
Member Author

asmorodskyi commented Aug 6, 2025

yeah I have missed declare function import , done , branch updated new VR is running http://openqa.suse.de/tests/18688576

ok this one failed too with different reason ... will paste new URL only after I will get green bubble :)

@asmorodskyi
Copy link
Member Author

asmorodskyi commented Aug 6, 2025

yeah I have missed declare function import , done , branch updated new VR is running http://openqa.suse.de/tests/18688576

ok this one failed too with different reason ... will paste new URL only after I will get green bubble :)

GREEN BUBBLE https://openqa.suse.de/tests/18690619# !!!

@grisu48 grisu48 merged commit abd38bb into os-autoinst:master Aug 7, 2025
12 checks passed
@asmorodskyi asmorodskyi mentioned this pull request Aug 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloviska mloviska mloviska left review comments

@m-dati m-dati m-dati left review comments

@pdostal pdostal pdostal approved these changes

@grisu48 grisu48 grisu48 approved these changes

@okurz okurz okurz approved these changes

@ricardobranco777 ricardobranco777 ricardobranco777 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@asmorodskyi @grisu48 @pdostal @okurz @ricardobranco777 @mloviska @m-dati