Enable check_guest_secure_boot() and remove record_soft_failure for bsc1182886.

[guoxuguang]

Enable check_guest_secure_boot() and remove record_soft_failure for bsc1182886.

• Related ticket: https://progress.opensuse.org/issues/178699
• Verification run:
  x86_64
  uefi-gi-guest_developing-on-host_developing-kvm pass
  sev-es-gi-guest_developing-on-host_developing-kvm pass
  aarch64
  uefi-gi-guest_developing-on-host_developing-kvm pass

[guoxuguang]

Add the latest validation run as below:
x86_64
uefi-gi-guest_developing-on-host_developing-kvm pass
sev-es-gi-guest_developing-on-host_developing-kvm pass
aarch64
uefi-gi-guest_developing-on-host_developing-kvm pass

[guoxuguang]

@alice-suse @Julie-CAO @waynechen55 @nanzhg @tbaev @RoyCai7 @martinsmarcelo
please help me review this PR. thanks

[guoxuguang]

Add the latest validation run as below:
uefi-gi-guest_developing-on-host_developing-kvm pass

Meanwhile, confirm enabled check_guest_secure_boot() part looks good - https://openqa.suse.de/tests/18523793#step/uefi_guest_verification/59

If there was no more new comment, this PR is ready to merge now. thanks

[Julie-CAO]

The ticke title is "Make UEFI and secure boot test work for sle16", so I think the "UEFI test"(check_guest_uefi_boot($_) ) should be run as well. Need @alice-suse to clarify the requirements.

[alice-suse]

The ticke title is "Make UEFI and secure boot test work for sle16", so I think the "UEFI test"(check_guest_uefi_boot($_) ) should be run as well. Need @alice-suse to clarify the requirements.

Based on contents of check_guest_uefi_boot (check for pxev6, httpv6 ), it is not necessary I think. The uefi checks are done mainly via

    $self->check_guest_bootloader($_) foreach (keys %virt_autotest::common::guests);
    $self->check_guest_bootcurrent($_) foreach (keys %virt_autotest::common::guests);

But if it is supported (having such in efibootmgr -v output), we can add the check too.

[alice-suse]

Thanks for adding secure boot check. LGTM.

[alice-suse]

@guoxuguang Are there ongoing validation runs after the last round of code update? Let me know when it is ready for merge :)

[guoxuguang]

@guoxuguang Are there ongoing validation runs after the last round of code update? Let me know when it is ready for merge :)

@alice-suse,
yes, there are ongoing validation runs after the last round of code update.

For now, finalize the latest validation runs as below:
x86_64
uefi-gi-guest_developing-on-host_developing-kvm pass

aarch64
uefi-gi-guest_developing-on-host_developing-kvm pass

Refer to the finalized validation run, test resutls looks good. this PR is readly to merge.
If there was no new comment, please help merge this PR. thanks