Refine az_validate_uuid_pattern API #22741
Open
+136
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpagot
force-pushed
the
az_validate_uuid_pattern_ut
branch
from
bfa8079 to
e32d0cf
Compare
Refine two azure_cli API: az_validate_uuid_pattern and az_storage_lease_acquire by defining some additional unit tests and improving the documentation. Fix all the API caller both in SDAF and QESAP lib.
mpagot
force-pushed
the
az_validate_uuid_pattern_ut
branch
from
e32d0cf to
97287e6
Compare
mpagot
requested review from
a-kpappas,
alvarocarvajald,
Amrysliu,
BillAnastasiadis,
emiura,
jankohoutek,
lilyeyes and
lpalovsky
as code owners
lilyeyes
reviewed
Jul 23, 2025
| @@ -1530,10 +1544,10 @@ sub az_resource_list { | |||
| sub az_validate_uuid_pattern { | |||
| my (%args) = @_; | |||
| croak "Mandatory argument 'uuid' missing" unless $args{uuid}; | |||
| my $pattern = '[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}'; | |||
| my $pattern = '^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$'; | |||
There was a problem hiding this comment.
I will remove the related code changes after your PR merged.
lilyeyes
approved these changes
Jul 23, 2025
|
There is a failure in http://openqaworker15.qa.suse.cz/tests/333692#step/configure/258 but it seems not related to this PR. |
Exactly. And that one does not result in the test to fail. Test fails in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine two azure_cli API: az_validate_uuid_pattern and az_storage_lease_acquire by defining some additional unit tests and improving the documentation.
Verification