Skip to content

Conversation

volodymyrkatkalov
Copy link
Contributor

Build LTP from source partially (due to kernel-azure and kABI)

Copy link
Contributor

@pevik pevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please adapt it also in our code?

sub install_selected_from_git {
prepare_ltp_git;
assert_script_run('pushd testcases');
foreach (get_submodules_to_rebuild()) {
assert_script_run("pushd $_ && make && make install && popd", timeout => 600);
}

Due the need to adapt the code also on two places I wished there would be in #22829 a single place to run the code. It'd be possible with a simple wrapper function which would either call $instance->run_ssh_command(...) (for PoC) or assert_script_run() (for QE kernel). The benefit would be that we never let your PoC runner fail in the future due possible necessary changes are implemented only in QE Kernel side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants