Add kernel parameters to bootloader section

[chcao]

• Related ticket: https://progress.opensuse.org/issues/184079
• Verification run: verification runs link
• Related mr: https://gitlab.suse.de/qe-yam/openqa-job-groups/-/merge_requests/563

[jknphy]

Please, rebase, there has been changes recently for bootloader timeout.
For this parameter, now we have the challengue that can go along a grub timeout stop or a grub timeout, but not both.
Is in progress: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/22904/files

[rakoenig]

Looks fine.

[manfredi]

Looks good.

[jknphy]

I have been discussing with @okynos different solutions, he will share with you regarding to have more compact libraries and not spreading value (not even keys) in the template.

[okynos]

Just a suggestion, discuss with @jknphy

[jknphy]

we should test further this, but a solution to have single function is this:
base.libsonnet:

{
  bootloader(bootloader, bootloader_timeout, bootloader_extra_kernel_params):: {
    [if bootloader || bootloader_timeout != '' || bootloader_extra_kernel_params != '' then 'bootloader']: std.prune({
      [if bootloader then 'stopOnBootMenu']: true,
      [if bootloader_timeout then 'timeout']: 15,
      [if bootloader_extra_kernel_params != '' then 'extraKernelParams']: bootloader_extra_kernel_params,
    }),
  },
  files: [{
    destination: '/usr/local/share/dummy.xml',
    url: 'dummy.xml',
  }],
  ...

template.libsonnet:

   ...
   storage='',
   user=true) (
  base_lib.bootloader(bootloader, bootloader_timeout, bootloader_extra_kernel_params) +
  {
    [if dasd == true then 'dasd']: dasd_lib.dasd(),
    ...
      }
)

Notice (, ) and + to make possible to use function directly in the function and merge it with the other keys.

[jknphy]

With a named regex without escaping the quotes twice (as you are escaping it after the equal and at the end):
get_var('AGAMA_PROFILE_OPTIONS', '') =~ /bootloader_extra_kernel_params="(?<kernel_params>.*)"/;

And then use it with:
$+{kernel_params}

[jknphy]

Do we really need \Q and \E, might be too much I think.
it would be read more naturally in one line:
die "$parameters not found in kernel command line!" unless $output =~ /$+{kernel_params}/);

[jknphy]

this operation is a parsing, it should go before running api call, like script_output, it is kind of an initialization (by extraction), although select_console might be an exception, you could put it after select_console, one line above.

[jknphy]

I'm not sure where I have seen this before, but please add your check on the bottom always, not on top, only for your debugging you could have it there while the PR is in WIP. It is not always the same rule, but when we are talking about specific checks, it applies, if we were doing some really generic check we would like to have it right after booting probably.
Additionally in theory it should match the order here: https://gitlab.suse.de/qe-yam/openqa-job-groups/-/merge_requests/563/diffs#5d8fe6da111ccf64f032b338d77178a533febb54_50_50 so it could easy guide us where things are.