Skip to content

Disable grub timeout in SLES for SAP 16.0 tests on pvm_hmc #23193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable grub timeout in SLES for SAP 16.0 tests on pvm_hmc #23193

wants to merge 1 commit into from
+8 −0

Conversation

alvarocarvajald
Copy link
Contributor

@alvarocarvajald alvarocarvajald commented Sep 2, 2025 •
edited
Loading

The default 8s timeout can cause some tests on pvm_hmc backend to fail as lib/sles4sap::reboot() would call 2 times lib/opensusebasetests::wait_grub(), and 8s could be not enough time to assert the grub screen twice.

This commit disables the grub timeout on SLES for SAP 16.0 installations by adding stopOnBootMenu in
data/sles4sap/agama/sles_sap_default_ppc64le.jsonnet and also adds on the related schedules the module installation/grub_test to handle the grub screen before first boot.

@okurz
Copy link
Member

okurz commented Sep 2, 2025

The default 8s timeout can cause some tests on pvm_hmc backend to fail as lib/sles4sap::reboot() would call 2 times lib/opensusebasetests::wait_grub(), and 8s could be not enough time to assert the grub screen twice.

This commit disables the grub timeout on SLES for SAP 16.0 installations by adding stopOnBootMenu in data/sles4sap/agama/sles_sap_default_ppc64le.jsonnet

Why do that only for SLES4SAP and only for ppc64le? IMHO the timeout should be disabled everywhere consistently

@alvarocarvajald
Copy link
Contributor Author

alvarocarvajald commented Sep 2, 2025 •
edited
Loading

The default 8s timeout can cause some tests on pvm_hmc backend to fail as lib/sles4sap::reboot() would call 2 times lib/opensusebasetests::wait_grub(), and 8s could be not enough time to assert the grub screen twice.
This commit disables the grub timeout on SLES for SAP 16.0 installations by adding stopOnBootMenu in data/sles4sap/agama/sles_sap_default_ppc64le.jsonnet

Why do that only for SLES4SAP and only for ppc64le? IMHO the timeout should be disabled everywhere consistently

I agree. We already did on qemu in fact, but left it as it was on the other architecturesbackends as it was working.

@okurz
Copy link
Member

okurz commented Sep 2, 2025

The default 8s timeout can cause some tests on pvm_hmc backend to fail as lib/sles4sap::reboot() would call 2 times lib/opensusebasetests::wait_grub(), and 8s could be not enough time to assert the grub screen twice.
This commit disables the grub timeout on SLES for SAP 16.0 installations by adding stopOnBootMenu in data/sles4sap/agama/sles_sap_default_ppc64le.jsonnet

Why do that only for SLES4SAP and only for ppc64le? IMHO the timeout should be disabled everywhere consistently

I agree. We already did on qemu in fact, but left it as it was on the other architecturesbackends as it was working.

But why keep it different then? I assume that sooner or later this will make problems and IMHO all those little differences make the analysis harder

mpagot
mpagot approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpalovsky
lpalovsky approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarocarvajald
Disable grub timeout in SLES for SAP 16.0 tests on pvm_hmc
f8b00b8 
The default 8s timeout can cause some tests on pvm_hmc backend
to fail as `lib/sles4sap::reboot()` would call 2 times
`lib/opensusebasetests::wait_grub()`, and 8s could be not enough time to
assert the grub screen twice.

This commit disables the grub timeout on SLES for SAP 16.0 installations
by adding `stopOnBootMenu: true` in
`data/sles4sap/agama/sles_sap_default_ppc64le.jsonnet` and also adds in
the related schedules the module `installation/grub_test` to handle the
grub screen before first boot.

Related Ticket: https://jira.suse.com/browse/TEAM-10611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpalovsky lpalovsky lpalovsky approved these changes

@mpagot mpagot mpagot approved these changes

@a-kpappas a-kpappas Awaiting requested review from a-kpappas a-kpappas is a code owner

@Amrysliu Amrysliu Awaiting requested review from Amrysliu Amrysliu is a code owner

@BillAnastasiadis BillAnastasiadis Awaiting requested review from BillAnastasiadis BillAnastasiadis is a code owner

@emiura emiura Awaiting requested review from emiura emiura is a code owner

@jankohoutek jankohoutek Awaiting requested review from jankohoutek jankohoutek is a code owner

@lilyeyes lilyeyes Awaiting requested review from lilyeyes lilyeyes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvarocarvajald @okurz @lpalovsky @mpagot