fix: update re.split calls to use maxsplit keyword argument#4709
Conversation
Signed-off-by: Emmanuel Ferdman <[email protected]>
terriko
approved these changes
Feb 5, 2025
Collaborator
terriko
left a comment
terriko
left a comment
There was a problem hiding this comment.
Sorry about the delay @emmanuel-ferdman -- I was out sick. I think this looks good and I've triggered the tests to run. They'll need to pass before it'll merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #4684
Starting from Python 3.13, using
maxsplitas a positional argument inre.splitis deprecated and will become keyword-only in future Python versions. Currently, this triggers the following warning:This PR updates the codebase to explicitly use
maxsplitas a keyword argument. Didn't find other instances of positionalmaxsplitusage in the codebase.For more information see the official Python docs.