Closed
Conversation
ffontaine
force-pushed
the
fix-cli-exit-code
branch
from
1943989 to
93dd994
Compare
Do not return 1 if CVEs are found as under Linux, it means that the program exited with a "General Error" Signed-off-by: Fabrice Fontaine <[email protected]>
ffontaine
force-pushed
the
fix-cli-exit-code
branch
from
93dd994 to
14ce9a2
Compare
terriko
requested changes
Feb 5, 2025
Collaborator
terriko
left a comment
terriko
left a comment
There was a problem hiding this comment.
I don't think we should change this: I know a number of users who rely on the exit code failure to tell if their automation/CI systems have detected new CVEs and act accordingly.
We could maybe consider using a different error code (although it does have to be a positive number because of undefined behaviour on windows), but we absolutely do need to return something other than 0 here or we're going to break a lot of stuff. This would have to be a 4.0 level breaking change, I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not return 1 if CVEs are found as under Linux, it means that the program exited with a "General Error"