feat(spdx_vex): Add support for SPDX VEX format using lib4vex (WIP)#4862
Closed
JigyasuRajput wants to merge 2 commits intoossf:mainfrom
Closed
feat(spdx_vex): Add support for SPDX VEX format using lib4vex (WIP)#4862JigyasuRajput wants to merge 2 commits intoossf:mainfrom
JigyasuRajput wants to merge 2 commits intoossf:mainfrom
Conversation
terriko
requested changes
Feb 27, 2025
Collaborator
terriko
left a comment
There was a problem hiding this comment.
Minor nit while I was quick scanning this to make sure nothing weird would happen if I allowed CI. I haven't actually done a full review but it looks safe to run the tests so I'll trigger those now.
| UnknownArchiveType: 31, | ||
| UnknownConfigType: 32, | ||
| CVEDataMissing: 33, | ||
| InvalidSpdxError: 33, |
Collaborator
There was a problem hiding this comment.
Probably just give this a new number for disambiguation from CVEDataMissing above. I don't really have these organized in any way so you can dump it at the bottom and use whatever the next number is.
Collaborator
|
This has a bunch of linter fails and I'm guessing you've got enough other stuff to work on, so I'm going to close it to help me pare down our open pull request list. Feel free to re-open if you want to work on it again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR; this PR needs work once lib4vex v0.3.0 is available as discussed in #4716
Description:
This PR aims to add support for the SPDX VEX format using
lib4vex. However, the required version (lib4vex 0.3.0) is not yet released.Current Status:
lib4vex 0.3.0is available.Next Steps: (once lib4vex v0.3.0 is available)
Marking this as a draft to track progress and get early feedback. Suggestions are welcome!
(WIP) - #4716