Skip to content

feat(synced-lyrics/lrclib): Fallback to plain search if no lyrics were found #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v01dling wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(synced-lyrics/lrclib): Fallback to plain search if no lyrics were found #4321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
470344c
Update LRCLib.ts
v01dling Feb 12, 2026
9e22503
Update LRCLib.ts
v01dling Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 14 additions & 29 deletions src/plugins/synced-lyrics/providers/LRCLib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,45 +39,33 @@ export class LRCLib implements LyricProvider {
throw new Error(`Expected an array, instead got ${typeof data}`);
}

// Flag to skip strict artist matching if we fall back to global search
let isFallback = false;

if (data.length === 0) {
if (!config()?.showLyricsEvenIfInexact) {
return null;
}

// Try to search with the alternative title (original language)
isFallback = true;
const trackName = alternativeTitle || title;
query = new URLSearchParams({ q: `${trackName}` });
query = new URLSearchParams({ q: trackName });
url = `${this.baseUrl}/api/search?${query.toString()}`;

response = await fetch(url);
if (!response.ok) {
throw new Error(`bad HTTPStatus(${response.statusText})`);
}

data = (await response.json()) as LRCLIBSearchResponse;
if (!Array.isArray(data)) {
throw new Error(`Expected an array, instead got ${typeof data}`);
}

// If still no results, try with the original title as fallback
if (data.length === 0 && alternativeTitle) {
query = new URLSearchParams({ q: title });
url = `${this.baseUrl}/api/search?${query.toString()}`;

response = await fetch(url);
if (!response.ok) {
throw new Error(`bad HTTPStatus(${response.statusText})`);
}

if (response.ok) {
data = (await response.json()) as LRCLIBSearchResponse;
if (!Array.isArray(data)) {
throw new Error(`Expected an array, instead got ${typeof data}`);
}
}
}

const filteredResults = [];
for (const item of data) {
// If we found lyrics via fallback query, skip strict artist matching
if (isFallback) {
filteredResults.push(item);
continue;
}

const { artistName } = item;

const artists = artist.split(/[&,]/g).map((i) => i.trim());
Expand Down Expand Up @@ -113,9 +101,8 @@ export class LRCLib implements LyricProvider {
tagPermutations.push([tag.toLowerCase(), itemArtist.toLowerCase()]);
}
}

// Compare each item artist with each tag
for (const itemArtist of itemArtists) {

// Compare each item artist with each tag
for (const tag of filteredTags) {
tagPermutations.push([itemArtist.toLowerCase(), tag.toLowerCase()]);
}
Expand All @@ -125,8 +112,6 @@ export class LRCLib implements LyricProvider {
const tagRatio = Math.max(
...tagPermutations.map(([x, y]) => jaroWinkler(x, y)),
);

// Use the best match ratio between direct artist match and tag match
ratio = Math.max(ratio, tagRatio);
}
}
Expand Down