-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Unified Downloader Implementation #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
9e328a3
188b8cb
2274d04
0f8f005
948babb
231b47a
bc0152b
bea76ca
af83790
1afa844
a25cabf
743dee8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -89,6 +89,7 @@ | |||
| "bgutils-js": "3.2.0", | ||||
| "butterchurn": "3.0.0-beta.5", | ||||
| "butterchurn-presets": "3.0.0-beta.4", | ||||
| "chalk": "^5.6.2", | ||||
|
||||
| "chalk": "^5.6.2", |
Copilot
AI
Feb 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@types/chalk is typically for older Chalk versions and can conflict with Chalk v5+, which ships its own types (and is ESM-only). If Chalk is kept, prefer relying on its bundled types and remove @types/chalk to avoid type resolution issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title/description focuses on a unified downloader, but this change introduces fork-specific README content about restoring an adblocker plugin and upstreaming workflow instructions. If this PR is intended for upstream, this README section is likely a mismatch and should be removed or moved to fork-only documentation.