Fix repeat mode resetting to off when switching tracks#4357
Open
bharatvansh wants to merge 1 commit intopear-devs:masterfrom
Open
Fix repeat mode resetting to off when switching tracks#4357bharatvansh wants to merge 1 commit intopear-devs:masterfrom
bharatvansh wants to merge 1 commit intopear-devs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a YouTube Music behavior where repeat mode was getting reset to Repeat Off whenever switching tracks.
The renderer now remembers the user-selected repeat mode (
ALL/ONE) and restores it after track data loads if YouTube resets it toNONE.Why
I was facing this issue locally: each track switch could reset repeat to off, which broke expected playback behavior. This should improve experience for all users who rely on repeat mode.
What changed
src/renderer.ts.peard:switch-repeat).videodatachange(dataloaded), restore preferred repeat mode if it was reset.Validation
pnpm build(passes)pnpm lintfails due existing repository-wide issues unrelated to this changepnpm typecheckfails due existing repository-wide issues unrelated to this changepnpm testhas 1 failing Playwright smoke test (tests/index.test.js) timing out in this environment; other tests pass