add shuffle #61

phalla-khong · 2016-12-13T01:45:24Z

add feature Shuffle

houndci-bot · 2016-12-13T01:45:32Z

src/21-directive-shuffleMusic.js

+ngSoundManager.directive('shuffleMusic', ['angularPlayer', function (angularPlayer) {
+        return {
+            restrict: "EA",
+            link: function (scope, element, attrs) {


'attrs' is defined but never used.

houndci-bot · 2016-12-13T01:45:32Z

src/21-directive-shuffleMusic.js

+ngSoundManager.directive('shuffleMusic', ['angularPlayer', function (angularPlayer) {
+        return {
+            restrict: "EA",
+            link: function (scope, element, attrs) {


'attrs' is defined but never used.

houndci-bot · 2016-12-13T01:45:32Z

src/21-directive-shuffleMusic.js

+            restrict: "EA",
+            link: function (scope, element, attrs) {
+
+                element.bind('click', function (event) {


'event' is defined but never used.

houndci-bot · 2016-12-13T01:45:32Z

src/21-directive-shuffleMusic.js

+            restrict: "EA",
+            link: function (scope, element, attrs) {
+
+                element.bind('click', function (event) {


'event' is defined but never used.

houndci-bot · 2016-12-13T01:45:32Z

src/21-directive-shuffleMusic.js

@@ -0,0 +1,18 @@
+ngSoundManager.directive('shuffleMusic', ['angularPlayer', function (angularPlayer) {
+        return {
+            restrict: "EA",


Mixed double and single quotes.

houndci-bot · 2016-12-13T01:45:32Z

src/21-directive-shuffleMusic.js

@@ -0,0 +1,18 @@
+ngSoundManager.directive('shuffleMusic', ['angularPlayer', function (angularPlayer) {
+        return {
+            restrict: "EA",


Mixed double and single quotes.

houndci-bot · 2016-12-13T01:45:32Z

src/21-directive-shuffleMusic.js

@@ -0,0 +1,18 @@
+ngSoundManager.directive('shuffleMusic', ['angularPlayer', function (angularPlayer) {


Line is too long.
'ngSoundManager' is not defined.

houndci-bot · 2016-12-13T01:45:33Z

src/21-directive-shuffleMusic.js

@@ -0,0 +1,18 @@
+ngSoundManager.directive('shuffleMusic', ['angularPlayer', function (angularPlayer) {


Line is too long.
'ngSoundManager' is not defined.

houndci-bot · 2016-12-13T01:45:33Z

src/03-factory-angularPlayer.js

+                } else {
+                    shuffle = true;
+                    tempTrack = angular.copy(soundManager.soundIDs);
+                    tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random() });


Line is too long.
Missing semicolon.

houndci-bot · 2016-12-13T01:45:33Z

src/03-factory-angularPlayer.js

+                } else {
+                    shuffle = true;
+                    tempTrack = angular.copy(soundManager.soundIDs);
+                    tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random() });


Line is too long.
Missing semicolon.

houndci-bot · 2016-12-13T01:45:33Z

src/03-factory-angularPlayer.js

+                    useTrack = tempTrack;
+                }
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2016-12-13T01:45:33Z

src/03-factory-angularPlayer.js

+                    useTrack = tempTrack;
+                }
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2016-12-13T01:45:33Z

src/03-factory-angularPlayer.js

+                    // generate shuffle track list
+                    if(shuffle === true && isPlaying === true){
+                        tempTrack = angular.copy(soundManager.soundIDs);
+                        tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random() });


Line is too long.
Missing semicolon.

houndci-bot · 2016-12-13T01:45:33Z

src/03-factory-angularPlayer.js

+                    // generate shuffle track list
+                    if(shuffle === true && isPlaying === true){
+                        tempTrack = angular.copy(soundManager.soundIDs);
+                        tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random() });


Line is too long.
Missing semicolon.

houndci-bot · 2016-12-13T01:45:33Z

src/03-factory-angularPlayer.js

+                console.log(soundManager.soundIDs);
+                console.log(tempTrack);
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2016-12-13T01:45:33Z

src/03-factory-angularPlayer.js

+                console.log(soundManager.soundIDs);
+                console.log(tempTrack);
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2016-12-13T02:04:51Z

src/03-factory-angularPlayer.js

+                    useTrack = tempTrack;
+                }
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2017-04-12T07:27:18Z

src/03-factory-angularPlayer.js

+                    useTrack = tempTrack;
+                }
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2017-04-12T07:41:08Z

src/03-factory-angularPlayer.js

+                    useTrack = tempTrack;
+                }
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2017-04-12T11:34:43Z

src/22-directive-shuffleAllMusic.js

+ngSoundManager.directive('shuffleAllMusic', ['angularPlayer', function (angularPlayer) {
+    return {
+        restrict: "EA",
+        link: function (scope, element, attrs) {


'attrs' is defined but never used.

houndci-bot · 2017-04-12T11:34:43Z

src/22-directive-shuffleAllMusic.js

+        restrict: "EA",
+        link: function (scope, element, attrs) {
+
+            element.bind('click', function (event) {


'event' is defined but never used.

houndci-bot · 2017-04-12T11:34:43Z

src/22-directive-shuffleAllMusic.js

@@ -0,0 +1,13 @@
+ngSoundManager.directive('shuffleAllMusic', ['angularPlayer', function (angularPlayer) {
+    return {
+        restrict: "EA",


Mixed double and single quotes.

houndci-bot · 2017-04-12T11:34:43Z

src/22-directive-shuffleAllMusic.js

@@ -0,0 +1,13 @@
+ngSoundManager.directive('shuffleAllMusic', ['angularPlayer', function (angularPlayer) {


Line is too long.
'ngSoundManager' is not defined.

houndci-bot · 2017-04-12T11:34:43Z

src/03-factory-angularPlayer.js

+                var trackToPlay = null;
+                shuffle = true;
+                tempTrack = angular.copy(soundManager.soundIDs);
+                tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random(); });


Line is too long.

houndci-bot · 2017-04-12T11:34:43Z

src/03-factory-angularPlayer.js

+                } else {
+                    shuffle = true;
+                    tempTrack = angular.copy(soundManager.soundIDs);
+                    tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random(); });


Line is too long.

houndci-bot · 2017-04-12T11:34:43Z

src/03-factory-angularPlayer.js

+                    useTrack = tempTrack;
+                }
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2017-04-12T11:34:43Z

src/03-factory-angularPlayer.js

+                    // generate shuffle track list
+                    if(shuffle === true && isPlaying === true){
+                        tempTrack = angular.copy(soundManager.soundIDs);
+                        tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random(); });


Line is too long.

houndci-bot · 2017-04-12T11:34:43Z

src/22-directive-shuffleAllMusic.js

+ngSoundManager.directive('shuffleAllMusic', ['angularPlayer', function (angularPlayer) {
+    return {
+        restrict: "EA",
+        link: function (scope, element, attrs) {


'attrs' is defined but never used.

houndci-bot · 2017-04-12T11:34:44Z

src/22-directive-shuffleAllMusic.js

+        restrict: "EA",
+        link: function (scope, element, attrs) {
+
+            element.bind('click', function (event) {


'event' is defined but never used.

houndci-bot · 2017-04-12T11:34:44Z

src/22-directive-shuffleAllMusic.js

@@ -0,0 +1,13 @@
+ngSoundManager.directive('shuffleAllMusic', ['angularPlayer', function (angularPlayer) {
+    return {
+        restrict: "EA",


Mixed double and single quotes.

houndci-bot · 2017-04-12T11:34:44Z

src/22-directive-shuffleAllMusic.js

@@ -0,0 +1,13 @@
+ngSoundManager.directive('shuffleAllMusic', ['angularPlayer', function (angularPlayer) {


Line is too long.
'ngSoundManager' is not defined.

houndci-bot · 2017-04-12T11:34:44Z

src/03-factory-angularPlayer.js

+                var trackToPlay = null;
+                shuffle = true;
+                tempTrack = angular.copy(soundManager.soundIDs);
+                tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random(); });


Line is too long.

houndci-bot · 2017-04-12T11:34:44Z

src/03-factory-angularPlayer.js

+                } else {
+                    shuffle = true;
+                    tempTrack = angular.copy(soundManager.soundIDs);
+                    tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random(); });


Line is too long.

houndci-bot · 2017-04-12T11:34:44Z

src/03-factory-angularPlayer.js

+                    useTrack = tempTrack;
+                }
+
+                var currentTrackKey = this.getIndexByValue(useTrack, this.getCurrentTrack());


Line is too long.

houndci-bot · 2017-04-12T11:34:44Z

src/03-factory-angularPlayer.js

+                    // generate shuffle track list
+                    if(shuffle === true && isPlaying === true){
+                        tempTrack = angular.copy(soundManager.soundIDs);
+                        tempTrack = (tempTrack).sort(function() { return 0.5 - Math.random(); });


Line is too long.

add shuffle

20575fd

houndci-bot reviewed Dec 13, 2016

View reviewed changes

fix some bug on shuffle

dc08c00

houndci-bot reviewed Dec 13, 2016

View reviewed changes

add auto play when shuffle

c59649d

houndci-bot reviewed Apr 12, 2017

View reviewed changes

grunt files

3c42459

houndci-bot reviewed Apr 12, 2017

View reviewed changes

add playShuffle feature

5766ac8

houndci-bot reviewed Apr 12, 2017

View reviewed changes

phalla added 3 commits April 21, 2017 09:33

fix bug on playNext

4d6c6ae

correct on playNext

2c8b258

add feature repeatTrack

3ff2ded

		@@ -0,0 +1,18 @@
		ngSoundManager.directive('shuffleMusic', ['angularPlayer', function (angularPlayer) {

		@@ -0,0 +1,13 @@
		ngSoundManager.directive('shuffleAllMusic', ['angularPlayer', function (angularPlayer) {

add shuffle #61

Are you sure you want to change the base?

add shuffle #61

Uh oh!

Conversation

phalla-khong commented Dec 13, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels