Skip to content

Clarify dns.blockESNI wording#2784

Open
darkexplosiveqwx wants to merge 1 commit intopi-hole:developmentfrom
darkexplosiveqwx:blockesni_description
Open

Clarify dns.blockESNI wording#2784
darkexplosiveqwx wants to merge 1 commit intopi-hole:developmentfrom
darkexplosiveqwx:blockesni_description

Conversation

@darkexplosiveqwx
Copy link

What does this PR aim to accomplish?:

Repaces #2690 and addresses #2690 (comment)

How does this PR accomplish the above?:

As noticed with #2690, I think that dns.blockESNI is obsolete, should I add a deprecation message of some kind?

I do think the current wording can be improved further.

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>
@darkexplosiveqwx darkexplosiveqwx requested a review from a team as a code owner February 22, 2026 18:23
@yubiuser yubiuser requested a review from DL6ER February 23, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant