Ensure API sessions are restored before starting the HTTP server#2803
Ensure API sessions are restored before starting the HTTP server#2803DL6ER merged 2 commits intodevelopmentfrom
Conversation
…e are not falsely rejecting still valid sessions Signed-off-by: Dominik <[email protected]>
|
The issue you tried to fix with your last commit
Happens for unkown reasons from time-to-time on Github. Usually, it's enough to restart the workflow. I just did it and the test passed now for amd64. |
|
I build a local image and with this FTL binary adding/removing CNAMES and switching pages works fine without logout. |
yubiuser
left a comment
There was a problem hiding this comment.
Assuming RISCV will finish one day and pass - could you please squash this down to two commits?
a5e1d09 to
0eb5fe8
Compare
…ermore, wait in Teleporter test until FTL is again ready. Otherwise, following tests may fail for unclear reasons Signed-off-by: Dominik <[email protected]>
0eb5fe8 to
9b1425b
Compare
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/webserver-session-timeout/85197/40 |
What does this implement/fix?
Restore API sessions way ahead of starting the web server to ensure we are not falsely rejecting still valid sessions. This is a regression of the asynchronous query importing as the thread importing the queries may get queued to only be able to restore the API sessions once history importing is done. This can take some time on slow devices.
Related issue or feature (if applicable): Fixes #2802
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentbranch.