Skip to content

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented Sep 4, 2025

Media construction would always do "%s %s" even if no Parameter was available. This commit fixes that by checking if Parameter is empty or not.

Resolves #3207

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.31%. Comparing base (457679c) to head (7809b8a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
+ Coverage   78.27%   78.31%   +0.03%     
==========================================
  Files          93       93              
  Lines       11906    11909       +3     
==========================================
+ Hits         9320     9327       +7     
+ Misses       2073     2071       -2     
+ Partials      513      511       -2     
Flag Coverage Δ
go 80.09% <100.00%> (+0.04%) ⬆️
wasm 63.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Media construction would always do "%s %s" even if no Parameter was
available. This commit fixes that by checking if Parameter is empty or
not.

Resolves #3207
@Sean-Der Sean-Der merged commit e9efed4 into master Sep 4, 2025
18 checks passed
@Sean-Der Sean-Der deleted the fix-3207 branch September 4, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SDP issue with a=rtcp-fb when there is no feedback parameter
1 participant