IBFlex: import multiple accounts from a single XML #5206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the IBFlex importer creates a new Client instead of using the one passed in to the constructor. This leads to it creating securities that already exist. Fix this by using the passed in client and adjusting a unit test which already specifies securities.
Refactor IBFlexStatementExtractorResult to represent the result of importing a single FlexStatement (i.e., one account) rather than an entire document. This prepares for supporting multiple accounts in a single IBFlex export file.
lmb
force-pushed
the
ibflex-multi-account
branch
from
db848b1 to
9a593a1
Compare
Use accountId and acctAlias in the XML export to find a matching portfolio. Use that so set portfolio and account on imported items if possible. This allows importing multiple IB accounts from a single XML file because the import wizard will now pre-populate portfolios and accounts. Allow specifying reference accounts in currencies other than the base currency by matching the reference account nameagainst the start of other account names. For example, a reference account named "IB" will match "IB1", "IB EUR", "IB GBP", etc. deposit accounts.
lmb
force-pushed
the
ibflex-multi-account
branch
from
9a593a1 to
18ba029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow importing multiple accounts from a single XML file by pre-populating Extractor.Item.accountPrimary, portfolioPrimary, etc.
Introduces a heuristic to be able to find reference accounts in different currencies.
See the commit messages for details.