Skip to content

Conversation

@Nirus2000
Copy link
Member

@Nirus2000
Copy link
Member Author

Hello @buchen
Please take a look at this change.

Specifically, it concerns the issue that if no exchange rate is available but one is required (see FlatExDegiroDividende13.txt), taxes are not included in the calculation, for example. I have adjusted lines 3597 to 3611, for example.
However, I'm not really happy with this. It would be better if we could address this issue for both taxes and fees and implement this in ExtractUtils.java (287 - 307). However, I'm missing the ParsedData v, which can set FAILURE.
Upon further consideration, the question of how to handle the .wrap() method and isFailure() via wrap((t, ctx) arises.

The goal would be to implement this point for all importers.

Regards
Alex

@Nirus2000 Nirus2000 force-pushed the Modify-FlatEx-PDF-Importer-to-support-new-transaction branch from bf9c12e to 4037944 Compare December 14, 2025 14:27
@Nirus2000 Nirus2000 force-pushed the Modify-FlatEx-PDF-Importer-to-support-new-transaction branch from 4037944 to 6ce7bae Compare December 14, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants