FIRE Calculation Widget#5527
Open
JGKle wants to merge 12 commits intoportfolio-performance:masterfrom
Open
Conversation
buchen
requested changes
Mar 1, 2026
Member
buchen
left a comment
There was a problem hiding this comment.
I like the idea of the in place editing. Nice.
- It should respect the Escape (typical example to cancel editing) and a click somewhere else (my second attempt to cancel editing).
- Editing should be activate by double click to keep consistent with the in-place editing of tables. Otherwise it confuses the user that it is sometimes a click, sometimes a double click.
See the other inline comments.
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/FIREWidget.java
Outdated
Show resolved
Hide resolved
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/FIREWidget.java
Outdated
Show resolved
Hide resolved
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/FIREWidget.java
Outdated
Show resolved
Hide resolved
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/FIREWidget.java
Outdated
Show resolved
Hide resolved
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/FIREWidget.java
Outdated
Show resolved
Hide resolved
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/FIREWidget.java
Outdated
Show resolved
Hide resolved
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/FIREWidget.java
Outdated
Show resolved
Hide resolved
name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/dashboard/FIREWidget.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks again for the quick review! I believe I addressed everything - could you take another look? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Dashboard widget for estimating progress toward FIRE (Financial Independence / Retire Early).
Reference/inspiration: https://engaging-data.com/fire-calculator